linux-kernel - Re: [PATCH] sched/cputime: remove irqtime_account_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c95e93d-c44c-b19e-62c0-b7c45c60e9e0@linux.alibaba.com>
Date:   Thu, 16 Jan 2020 11:44:28 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/cputime: remove irqtime_account_idle_ticks



在 2020/1/16 上午11:17, Alex Shi 写道:
> irqtime_account_idle_ticks just add longer call path w/o enough meaning.
> We don't bother remove this function to simply code and reduce a
> bit object size of kernel.

Sorry, above commit log need to revise as following:

irqtime_account_idle_ticks just add longer call path w/o enough meaning.
We'd better to remove this function to simply code and reduce a bit object
size of kernel.

> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Ingo Molnar <mingo@...hat.com> 
> Cc: Peter Zijlstra <peterz@...radead.org> 
> Cc: Juri Lelli <juri.lelli@...hat.com> 
> Cc: Vincent Guittot <vincent.guittot@...aro.org> 
> Cc: Dietmar Eggemann <dietmar.eggemann@....com> 
> Cc: Steven Rostedt <rostedt@...dmis.org> 
> Cc: Ben Segall <bsegall@...gle.com> 
> Cc: Mel Gorman <mgorman@...e.de> 
> Cc: linux-kernel@...r.kernel.org 
> ---
>  kernel/sched/cputime.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index cff3e656566d..17640d145e44 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -390,12 +390,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick,
>  	}
>  }
>  
> -static void irqtime_account_idle_ticks(int ticks)
> -{
> -	irqtime_account_process_tick(current, 0, ticks);
> -}
>  #else /* CONFIG_IRQ_TIME_ACCOUNTING */
> -static inline void irqtime_account_idle_ticks(int ticks) { }
>  static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick,
>  						int nr_ticks) { }
>  #endif /* CONFIG_IRQ_TIME_ACCOUNTING */
> @@ -505,7 +500,7 @@ void account_idle_ticks(unsigned long ticks)
>  	u64 cputime, steal;
>  
>  	if (sched_clock_irqtime) {
> -		irqtime_account_idle_ticks(ticks);
> +		irqtime_account_process_tick(current, 0, ticks);
>  		return;
>  	}
>  
>