linux-kernel - Re: [PATCH -next] drivers/net: netdevsim depends on INET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200116050506.18c2cce3@cakuba.hsd1.ca.comcast.net>
Date:   Thu, 16 Jan 2020 05:05:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hongbo Yao <yaohongbo@...wei.com>
Cc:     <chenzhou10@...wei.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drivers/net: netdevsim depends on INET

On Thu, 16 Jan 2020 20:52:19 +0800, Hongbo Yao wrote:
> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
> 
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
> 
> Correct the Kconfig for netdevsim.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 83c9e13aa39ae("netdevsim: add software driver for testing
> offloads")

Please provide a _correct_ Fixes tag, and don't line wrap it.
The commit you're pointing to doesn't use any of the fib functions 
so how can it be to blame?

> Signed-off-by: Hongbo Yao <yaohongbo@...wei.com>
> ---
>  drivers/net/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 77ee9afad038..25a8f9387d5a 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -549,6 +549,7 @@ source "drivers/net/hyperv/Kconfig"
>  config NETDEVSIM
>  	tristate "Simulated networking device"
>  	depends on DEBUG_FS
> +	depends on INET
>  	depends on IPV6 || IPV6=n
>  	select NET_DEVLINK
>  	help