linux-kernel - Re: [PATCH] usb: gadget: ffs: ffs_aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9943963591465db81be57d4e1bb98ac4cd16d9b2.camel@analog.com>
Date:   Thu, 16 Jan 2020 13:05:37 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "balbi@...nel.org" <balbi@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mina86@...a86.com" <mina86@...a86.com>,
        "lars@...afoo.de" <lars@...afoo.de>
Subject: Re: [PATCH] usb: gadget: ffs: ffs_aio_cancel(): Save/restore IRQ
 flags

On Thu, 2020-01-16 at 15:04 +0200, Felipe Balbi wrote:
> [External]
> 
> 
> Hi,
> 
> "Ardelean, Alexandru" <alexandru.Ardelean@...log.com> writes:
> 
> > On Wed, 2019-11-06 at 14:02 +0200, Alexandru Ardelean wrote:
> > > From: Lars-Peter Clausen <lars@...afoo.de>
> > > 
> > > ffs_aio_cancel() can be called from both interrupt and thread
> > > context.
> > > Make
> > > sure that the current IRQ state is saved and restored by using
> > > spin_{un,}lock_irq{save,restore}().
> > > 
> > > Otherwise undefined behavior might occur.
> > 
> > Hey,
> > 
> > This is a patch-ping.
> 
> Please read:
> 
> https://lore.kernel.org/linux-usb/875zhd6pw0.fsf@kernel.org/T/#u
> 
> We're gonna need a resend, sorry
> 

Ack.

Thanks for the reply.
Will re-send.