linux-kernel - Re: [PATCH] KVM: arm/arm64: Fix some obsolete comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 16 Jan 2020 02:01:27 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     "maz@...nel.org" <maz@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "julien.thierry.kdev@...il.com" <julien.thierry.kdev@...il.com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "christoffer.dall@....com" <christoffer.dall@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "will@...nel.org" <will@...nel.org>,
        "andre.przywara@....com" <andre.przywara@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] KVM: arm/arm64: Fix some obsolete comments

friendly ping. :)
> From: Miaohe Lin <linmiaohe@...wei.com>
>
> Fix various comments, including comment typo, and obsolete comments no longer make sense.
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  virt/kvm/arm/arch_timer.c    | 5 ++---
>  virt/kvm/arm/arm.c           | 1 -
>  virt/kvm/arm/vgic/vgic-its.c | 2 +-
>  3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c index 73867f97040c..d8d2f4bec935 100644
> --- a/virt/kvm/arm/arch_timer.c
> +++ b/virt/kvm/arm/arch_timer.c
> @@ -322,9 +322,8 @@ static void timer_emulate(struct arch_timer_context *ctx)
>  	}
>  
>  	/*
> -	 * If the timer can fire now, we don't need to have a soft timer
> -	 * scheduled for the future.  If the timer cannot fire at all,
> -	 * then we also don't need a soft timer.
> +	 * If the timer cannot fire at all, we don't need to have a
> +	 * soft timer scheduled for the future.
>  	 */
>  	if (!kvm_timer_irq_can_fire(ctx)) {
>  		soft_timer_cancel(&ctx->hrtimer);
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 8de4daf25097..7687663ab71b 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -525,7 +525,6 @@ static bool need_new_vmid_gen(struct kvm_vmid *vmid)
>  
>  /**
>   * update_vmid - Update the vmid with a valid VMID for the current generation
> - * @kvm: The guest that struct vmid belongs to
>   * @vmid: The stage-2 VMID information struct
>   */
>  static void update_vmid(struct kvm_vmid *vmid) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index 98c7360d9fb7..d64569b30b5c 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -2564,7 +2564,7 @@ static int vgic_its_restore_collection_table(struct vgic_its *its)  }
>  
>  /**
> - * vgic_its_save_tables_v0 - Save the ITS tables into guest ARM
> + * vgic_its_save_tables_v0 - Save the ITS tables into guest RAM
>   * according to v0 ABI
>   */
>  static int vgic_its_save_tables_v0(struct vgic_its *its)
> --
> 2.19.1
>