linux-kernel - Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adeadf1f-df85-8af1-ccbd-fc8ff2cb4d43@gmail.com>
Date:   Thu, 16 Jan 2020 16:05:48 -0800
From:   Shiping Ji <shiping.linux@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     James Morse <james.morse@....com>, robh+dt@...nel.org,
        mark.rutland@....com, devicetree@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-edac@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        sashal@...nel.org, hangl@...rosoft.com,
        Lei Wang <lewan@...rosoft.com>, ruizhao@...rosoft.com,
        shji@...rosoft.com, Scott Branden <scott.branden@...adcom.com>,
        Yuqing Shen <yuqing.shen@...adcom.com>, ray.jui@...adcom.com,
        wangglei@...il.com
Subject: Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt

On 1/16/2020 3:39 PM, Borislav Petkov wrote:
> On Wed, Jan 15, 2020 at 06:32:27AM -0800, Shiping Ji wrote:
>> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>>
>> Signed-off-by: Shiping Ji <shiping.linux@...il.com>
>> Signed-off-by: Lei Wang <leiwang_git@...look.com>
>> Reviewed-by: James Morse <james.morse@....com>
> 
> So for this patch, v2 had Rui Zhao as an author:
> 
> https://lkml.kernel.org/r/BN7PR08MB5572B3388B2D7DC8F6C7F285AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com
> 
> v3 got Lei as an author:
> 
> https://lkml.kernel.org/r/CY1PR0401MB1244062C1738B09D6100F202860A0@CY1PR0401MB1244.namprd04.prod.outlook.com
> 
> and now it is you.
> 
> So when you send next time, think about who's going to be the author.

I'll make sure Lei is the author (From:) in the next patches.

>> +     line numbers. The valid interrupt names are the followings:
> 
> WARNING: 'followings' may be misspelled - perhaps 'following'?
> #51: FILE: Documentation/devicetree/bindings/edac/arm-dmc520.txt:10:
> +     line numbers. The valid interrupt names are the followings:

Yes, I think this can be fixed. I checked the scripts/spelling.txt and it does suggest using 'following' instead.
 
> Please integrate scripts/checkpatch.pl into your patch creation
> workflow. Some of the warnings/errors *actually* make sense.

Yes, we will.

> Also, this patch throws this other checkpatch warning:
> 
> WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst
> 
> but since Rob reviewed it, I'm going to assume checkpatch is wrong here.
> 
> Thx.
 
The check seems to warn the next file in .txt format which should be rather in the new .yaml format. We'll try to make one next.

Thanks!

-- 
Best regards,
Shiping Ji