linux-kernel - Re: [PATCH v2 7/9] scsi: ufs: Add max_lu_supported in struct ufs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3332e2a9-f720-4127-af57-afb6cccef9a2@acm.org>
Date:   Thu, 16 Jan 2020 20:02:19 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <huobean@...il.com>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/9] scsi: ufs: Add max_lu_supported in struct
 ufs_dev_info

On 2020-01-16 13:59, Bean Huo wrote:
> From: Bean Huo <beanhuo@...ron.com>
> 
> Add one new parameter max_lu_supported in struct ufs_dev_info,
> which will be used to express exactly how many general LUs being
> supported by UFS device.
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> Reviewed-by: Asutosh Das <asutoshd@...eaurora.org>
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>  drivers/scsi/ufs/ufs.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
> index fcc9b4d4e56f..c982bcc94662 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -530,6 +530,8 @@ struct ufs_dev_info {
>  	bool f_power_on_wp_en;
>  	/* Keeps information if any of the LU is power on write protected */
>  	bool is_lu_power_on_wp;
> +	/* Maximum number of general LU supported by the UFS device */
> +	u8 max_lu_supported;
>  	u16 wmanufacturerid;
>  	/*UFS device Product Name */
>  	u8 *model;

There is a strong tradition in the Linux kernel community of introducing
structure members in the same patch that introduces the first user of
such a structure member. I think patch 8/9 is the first patch that uses
this structure member. Please consider combining patches 7/9 and 8/9
into a single patch.

Thanks,

Bart.