linux-kernel - RE: [EXT] Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN7PR08MB5684A86FC0922C3AC2DF93A3DB310@BN7PR08MB5684.namprd08.prod.outlook.com>
Date:   Fri, 17 Jan 2020 12:55:03 +0000
From:   "Bean Huo (beanhuo)" <beanhuo@...ron.com>
To:     Bart Van Assche <bvanassche@....org>, Bean Huo <huobean@...il.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc

Hi, Bart

> On 2020-01-16 13:59, Bean Huo wrote:
> >  struct ufs_dev_fix {
> > -	struct ufs_dev_desc card;
> > +	u16 wmanufacturerid;
> > +	u8 *model;
> >  	unsigned int quirk;
> >  };
> >
> > -#define END_FIX { { 0 }, 0 }
> > +#define END_FIX { 0 }
> 
> A minor comment: please use { } instead of { 0 }.
> 
Will be changed in the next version.

> >  /* add specific device quirk */
> >  #define UFS_FIX(_vendor, _model, _quirk) { \
> > -	.card.wmanufacturerid = (_vendor),\
> > -	.card.model = (_model),		   \
> > +	.wmanufacturerid = (_vendor),\
> > +	.model = (_model),		   \
> >  	.quirk = (_quirk),		   \
> >  }
> 
> Is this macro useful? Does it improve readability of the code? If not, how about
> removing it (maybe later)?
> 
Before no better solution,  I think now we just keep it. 
> Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>
Thanks for reviewing.

//Bean