linux-kernel - Re: [PATCH] ARM: dts: colibri-imx7: fix ethernet performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGgjyvEOBeh_qQwimOT6Nk=nvq=1_+2ByBQkgY4F=XHE0J3BhQ@mail.gmail.com>
Date:   Fri, 17 Jan 2020 19:25:28 +0000
From:   Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
To:     Lucas Stach <l.stach@...gutronix.de>
CC:     Oleksandr Suvorov <oleksandr.suvorov@...adex.com>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Igor Opanyuk <igor.opanyuk@...adex.com>,
        Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: colibri-imx7: fix ethernet performance

2mntnrs: please ignore this patchset.

On Thu, Jan 16, 2020 at 1:35 PM Lucas Stach <l.stach@...gutronix.de> wrote:
>
> On Do, 2020-01-16 at 10:13 +0000, Oleksandr Suvorov wrote:
> > Performance test of ethernet interface shows extremely low result:
> >
> > === w/o fix =================
> > Connecting to host 192.168.x.x, port 5201
> > [  5] local 192.168.x.y port59020 connected to 192.168.x.x port 5201
> > ...
> > [ ID] Interval           Transfer     Bitrate         Retr
> > [  5]   0.00-10.00  sec  2.78 MBytes  2.33 Mbits/sec  337      sender
> > [  5]   0.00-10.00  sec  2.66 MBytes  2.23
> > Mbits/sec           receiver
> > =============================
> >
> > Adding correct settings of the mdio bus with the respective phy
> > fixes this issue.
>
> So what's the actual issue being fixed here? High packet loss due to
> trying to force GBit speeds through 100MBit magnetics? So the addition
> of "max-speed = <100>;" is the real core of the fix?

Lucas, max-speed is not the core of this fix, actually, Micrel 8041 is
a 10/100 phy only.
But thank you for paying attention to this patchset. This is just a
part of a fix,
and it was mistakenly posted partially and with messed commit log.
I'll resend a complete solution when it is ready and retested again.

> The commit log should mention this.
>
> Regards,
> Lucas
>
> >
> > === after fix ===============
> > iperf3 -c 192.168.x.x
> > Connecting to host 192.168.x.x, port 5201
> > [  5] local 192.168.x.y port 50702 connected to 192.168.x.x port 5201
> > ...
> > [ ID] Interval           Transfer     Bitrate         Retr
> > [  5]   0.00-10.00  sec   114 MBytes  95.4 Mbits/sec   56      sender
> > [  5]   0.00-10.00  sec   112 MBytes  94.1
> > Mbits/sec           receiver
> > =============================
> >
> > Fixed: commit b326629f25b7 ("ARM: dts: imx7: add Toradex Colibri
> >                     iMX7S/iMX7D support")
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> >
> > ---
> >
> >  arch/arm/boot/dts/imx7-colibri.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> > b/arch/arm/boot/dts/imx7-colibri.dtsi
> > index d05be3f0e2a7..7b6a7c124345 100644
> > --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> > @@ -115,7 +115,20 @@ &fec1 {
> >       assigned-clock-rates = <0>, <100000000>;
> >       phy-mode = "rmii";
> >       phy-supply = <&reg_LDO1>;
> > +     phy-handle = <&ethphy0>;
> >       fsl,magic-packet;
> > +
> > +     mdio {
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             ethphy0: ethernet-phy@0 {
> > +                     compatible = "ethernet-phy-ieee802.3-c22";
> > +                     max-speed = <100>;
> > +                     micrel,led-mode = <0>;
> > +                     reg = <0>;
> > +             };
> > +     };
> >  };
> >
> >  &flexcan1 {
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)