linux-kernel - Re: [PATCH 0/4] drm/i915/display: conversion to new logging macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.99999.375.2001172219550.18007@wambui>
Date:   Fri, 17 Jan 2020 22:25:44 +0300 (EAT)
From:   Wambui Karuga <wambui.karugax@...il.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
cc:     Wambui Karuga <wambui.karugax@...il.com>,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch, sean@...rly.run,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] drm/i915/display: conversion to new logging
 macros.



On Fri, 17 Jan 2020, Jani Nikula wrote:

> On Thu, 16 Jan 2020, Wambui Karuga <wambui.karugax@...il.com> wrote:
>> This series converts the printk based logging macros in
>> drm/i915/display/intel_display.c to the new struct drm_device based
>> logging macros. This change was split into four for manageability and
>> due to the size of drm/i915/display/intel_display.c.
>
> Please still write more descriptive commit messages than "part N".
>
What would be a more descriptive subject line? I wasn't really sure about 
the subject line since the series is for the same file - which is why I 
went with "part N".

> What are your basing your patches on? Our CI uses 
drm-tip, and it's > failing to apply the patches.
>
I'm using drm-tip, but I can rebase and try again.

Thanks.
wambui.
> BR,
> Jani.
>
>
>
>>
>> Wambui Karuga (4):
>>   drm/i915/display: conversion to new logging macros part 1
>>   drm/i915/display: conversion to new logging macros part 2
>>   drm/i915/display: conversion to new logging macros part 3
>>   drm/i915/display: convert to new logging macros part 4.
>>
>>  drivers/gpu/drm/i915/display/intel_display.c | 1021 ++++++++++--------
>>  1 file changed, 596 insertions(+), 425 deletions(-)
>
> -- 
> Jani Nikula, Intel Open Source Graphics Center
>