linux-kernel - Re: [PATCH bpf-next] bpf: Fix memory leaks in generic update/delete batch ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d954f70-a2d0-85c7-33c8-c71d6ed9572d@fb.com>
Date:   Sat, 18 Jan 2020 04:14:07 +0000
From:   Yonghong Song <yhs@...com>
To:     Brian Vazquez <brianvv@...gle.com>,
        Brian Vazquez <brianvv.kernel@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH bpf-next] bpf: Fix memory leaks in generic update/delete
 batch ops



On 1/17/20 2:56 PM, Brian Vazquez wrote:
> generic update/delete batch ops functions were using __bpf_copy_key
> without properly freeing the memory. Handle the memory allocation and
> copy_from_user separately.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: aa2e93b8e58e ("bpf: Add generic support for update and delete
> batch ops")

Please put the subject of Fixes commit in the same line.
This will make tools easier to grep "Fixes" tag.

> Signed-off-by: Brian Vazquez <brianvv@...gle.com>

Acked-by: Yonghong Song <yhs@...com>