linux-kernel - Re: [PATCH] mtd: spi-nor: Add support for at25sl321

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2121499.oPre2Eb8Qh@192.168.0.113>
Date:   Sun, 19 Jan 2020 07:18:29 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <michael@...le.cc>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>
Subject: Re: [PATCH] mtd: spi-nor: Add support for at25sl321

On Thursday, January 16, 2020 6:02:09 PM EET Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> This was tested in single, dual and quad mode on a custom board with the
> NXP FlexSPI controller.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 8226d6450069..94747059344a 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2332,6 +2332,12 @@ static const struct flash_info spi_nor_ids[] = {
> 
>         { "at45db081d", INFO(0x1f2500, 0, 64 * 1024, 16, SECT_4K) },
> 
> +       /* Adesto (former Atmel) */

All the atmel flashes from above start with Adesto's manufacturer id, 0x1f.
I dropped this comment, ordered the entry alphabetically and applied to spi-
nor/next. Thanks.
ta

> +       {
> +               "at25sl321",  INFO(0x1f4216, 0, 64 * 1024, 64,
> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> +       },
> +
>         /* EON -- en25xxx */
>         { "en25f32",    INFO(0x1c3116, 0, 64 * 1024,   64, SECT_4K) },
>         { "en25p32",    INFO(0x1c2016, 0, 64 * 1024,   64, 0) },
> --
> 2.20.1