linux-kernel - RE: [PATCH V4 0/4] Add Xilinx's ZynqMP AES-GCM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN7PR02MB51241CCD25BD1269B4394D9AAF320@BN7PR02MB5124.namprd02.prod.outlook.com>
Date:   Mon, 20 Jan 2020 06:59:22 +0000
From:   Kalyani Akula <kalyania@...inx.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     git <git@...inx.com>, Harsh Jain <harshj@...inx.com>,
        Sarat Chand Savitala <saratcha@...inx.com>,
        Mohan Marutirao Dhanawade <mohand@...inx.com>,
        Kalyani Akula <kalyania@...inx.com>
Subject: RE: [PATCH V4 0/4] Add Xilinx's ZynqMP AES-GCM driver support

Hi Herbert,

Any review comments on below patch set.

Regards,
Kalyani

> -----Original Message-----
> From: Kalyani Akula <kalyani.akula@...inx.com>
> Sent: Wednesday, November 20, 2019 1:14 PM
> To: linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: git <git@...inx.com>; Harsh Jain <harshj@...inx.com>; Sarat Chand
> Savitala <saratcha@...inx.com>; Mohan Marutirao Dhanawade
> <mohand@...inx.com>; Kalyani Akula <kalyania@...inx.com>; Kalyani Akula
> <kalyania@...inx.com>
> Subject: [PATCH V4 0/4] Add Xilinx's ZynqMP AES-GCM driver support
> 
> This patch set adds support for
> - dt-binding docs for Xilinx ZynqMP AES driver
> - Adds device tree node for ZynqMP AES driver
> - Adds communication layer support for aes in zynqmp.c
> - Adds Xilinx ZynqMP driver for AES Algorithm
> 
> V4 Changes :
> - Addressed review comments.
> 
> V3 Changes :
> - Added software fallback in cases where HW doesnt have  the capability to
> handle the request.
> - Removed use of global variable for storing the driver data.
> - Enabled CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y and executed all
> the kernel selftests. Also covered tests with tcrypt module.
> 
> V2 Changes :
> - Converted RFC PATCH to PATCH
> - Removed ALG_SET_KEY_TYPE that was added to support keytype
>   attribute. Taken using setkey interface.
> - Removed deprecated BLKCIPHER in Kconfig
> - Erased Key/IV from the buffer.
> - Renamed zynqmp-aes driver to zynqmp-aes-gcm.
> - Addressed few other review comments
> 
> 
> Kalyani Akula (4):
>   dt-bindings: crypto: Add bindings for ZynqMP AES driver
>   ARM64: zynqmp: Add Xilinix AES node.
>   firmware: xilinx: Add ZynqMP aes API for AES functionality
>   crypto: Add Xilinx AES driver
> 
>  .../devicetree/bindings/crypto/xlnx,zynqmp-aes.txt |  12 +
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi             |   5 +
>  drivers/crypto/Kconfig                             |  11 +
>  drivers/crypto/Makefile                            |   1 +
>  drivers/crypto/xilinx/Makefile                     |   3 +
>  drivers/crypto/xilinx/zynqmp-aes-gcm.c             | 469
> +++++++++++++++++++++
>  drivers/firmware/xilinx/zynqmp.c                   |  23 +
>  include/linux/firmware/xlnx-zynqmp.h               |   2 +
>  8 files changed, 526 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.txt
>  create mode 100644 drivers/crypto/xilinx/Makefile  create mode 100644
> drivers/crypto/xilinx/zynqmp-aes-gcm.c
> 
> --
> 1.9.5