linux-kernel - Re: [PATCH] x86/fpu: remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73a88e85-6995-6e3e-5eb8-a8c2b233364d@intel.com>
Date:   Tue, 21 Jan 2020 15:07:23 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Cyrill Gorcunov <gorcunov@...il.com>,
        Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu: remove unused macros

On 1/21/20 3:43 AM, Cyrill Gorcunov wrote:
> On Tue, Jan 21, 2020 at 04:50:11PM +0800, Alex Shi wrote:
>> NR_VALID_PKRU_BITS/PKRU_VALID_MASK are never used after it was
>> introduced. So better to remove them.
> Dave moved them in so while they are not used indeed better to
> get approve from him (to be sure they were not reserved for
> future development).
> 
> Initial commit 8459429693395ca9e8d18101300b120ad9171795

FWIW, I'm not a massive fan of blindly removing stuff like this.  Maybe
it's better to remove the cruft, but it's even better to try to figure
out why I might have added them in the first place. :)

I *think* it was an attempt to ensure that a resulting PKRU value can be
written to PKRU, independent of the type it was stored as.

Let me see if I can come up with something nicer than ripping these out.