linux-kernel - Re: [PATCH] x86/fpu: remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200122065146.GI2437@uranus>
Date:   Wed, 22 Jan 2020 09:51:46 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     Alex Shi <alex.shi@...ux.alibaba.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu: remove unused macros

On Tue, Jan 21, 2020 at 03:07:23PM -0800, Dave Hansen wrote:
> FWIW, I'm not a massive fan of blindly removing stuff like this.  Maybe
> it's better to remove the cruft, but it's even better to try to figure
> out why I might have added them in the first place. :)
> 
> I *think* it was an attempt to ensure that a resulting PKRU value can be
> written to PKRU, independent of the type it was stored as.
> 
> Let me see if I can come up with something nicer than ripping these out.

Sure. Thanks a huge, Dave!