linux-kernel - Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 19:47:13 +0800
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
To:     Vignesh Raghavendra <vigneshr@...com>, broonie@...nel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     robh+dt@...nel.org, dan.carpenter@...cle.com,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com
Subject: Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence
 QSPI controller

Hi,

On 15/1/2020 2:21 PM, Ramuthevar, Vadivel MuruganX wrote:
> Hi,
>
> On 15/1/2020 2:13 PM, Vignesh Raghavendra wrote:
>> Hi,
>>
>> On 12/30/2019 1:11 PM, Ramuthevar,Vadivel MuruganX wrote:
>>> Add support for the Cadence QSPI controller. This controller is
>>> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs.
>>> This driver has been tested on the Intel LGM SoCs.
>>>
>>> This driver does not support generic SPI and also the implementation
>>> only supports spi-mem interface to replace the existing driver in
>>> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR
>>> flash memory.
>>>
>>
>>
>> I am finally able to get spi-mem based cadence-quaspi driver working on
>> TI platforms with DMA and DAC mode. I have also incorporated changes to
>> disable DAC and autopolling for your intel SoC:
>
> Thanks! a lot for the confirmation, with your changes it is working on 
> TI platform.
>
>> https://github.com/r-vignesh/linux/commits/qspi
>>
>> (Top two patches are of interest)
>>
>> I have tested both DAC and INDAC mode with s25fl flash and everything
>> seems to be fine. Could you re test the driver on your SoC? 

while re-testing QSPI_NOR/NAND both didn't work, after few changes from 
patchV6 followed by your changes,

now QSPI-NOR started working,  soon will be sending updated patch 
version which includes your changes as well as my changes

without affecting both the platforms(TI and Intel).

BTW,  Have you tested QSPI-NAND on your platform ? with our patches.

Thanks! for your review and support.

Regards
Vadivel
>> Feel free to
>> fold it into your series if everything works.
> sure, I will test on Intel SoC with your changes .
>
> Regards
> Vadivel
>> Regards
>> Vignesh
>>
>>
>>