linux-kernel - RE: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0402MB355668F205AD711D2059CDB5E00F0@AM0PR0402MB3556.eurprd04.prod.outlook.com>
Date:   Thu, 23 Jan 2020 07:24:26 +0000
From:   Kuldeep Singh <kuldeep.singh@....com>
To:     Vignesh Raghavendra <vigneshr@...com>,
        "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "cheol.yong.kim@...el.com" <cheol.yong.kim@...el.com>,
        "qi-ming.wu@...el.com" <qi-ming.wu@...el.com>
Subject: RE: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for
 the Cadence QSPI controller

Hi Vignesh,

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org <linux-kernel-
> owner@...r.kernel.org> On Behalf Of Vignesh Raghavendra
> Sent: Wednesday, January 15, 2020 11:43 AM
> To: Ramuthevar,Vadivel MuruganX
> <vadivel.muruganx.ramuthevar@...ux.intel.com>; broonie@...nel.org; linux-
> spi@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: robh+dt@...nel.org; dan.carpenter@...cle.com;
> cheol.yong.kim@...el.com; qi-ming.wu@...el.com
> Subject: [EXT] Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the
> Cadence QSPI controller
> 
> Caution: EXT Email
> 
> Hi,
> 
> On 12/30/2019 1:11 PM, Ramuthevar,Vadivel MuruganX wrote:
> > Add support for the Cadence QSPI controller. This controller is
> > present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs.
> > This driver has been tested on the Intel LGM SoCs.
> >
> > This driver does not support generic SPI and also the implementation
> > only supports spi-mem interface to replace the existing driver in
> > mtd/spi-nor/cadence-quadspi.c, the existing driver only support
> > SPI-NOR flash memory.
> >
> 
> 
> 
> I am finally able to get spi-mem based cadence-quaspi driver working on TI
> platforms with DMA and DAC mode. I have also incorporated changes to
> disable DAC and autopolling for your intel SoC:
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
> m%2Fr-
> vignesh%2Flinux%2Fcommits%2Fqspi&amp;data=02%7C01%7Ckuldeep.singh%
> 40nxp.com%7Ccbd14ac527ae4298a28808d7998219e6%7C686ea1d3bc2b4c6fa
> 92cd99c5c301635%7C0%7C0%7C637146656365872638&amp;sdata=jAR7lmry
> R9fdqF3e4A2dQzF0Q0fYxMvM7sNhx8lvoy0%3D&amp;reserved=0
> 
> (Top two patches are of interest)
> 
> I have tested both DAC and INDAC mode with s25fl flash and everything seems
> to be fine. Could you re test the driver on your SoC? Feel free to fold it into
> your series if everything works.

Is JFFS2/UBIFS a valid use case here? And were you able to test the same?
I see few issues with Spansion flashes (s25fs) in framework and couldn’t make FS utilities run.
On the other hand, file systems on other flashes (ex: micron, mt25qu) are showing positive results.

Thanks
Kuldeep

> 
> Regards
> Vignesh
> 
>