linux-kernel - Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200121145907.7fef0316@xps13>
Date:   Tue, 21 Jan 2020 14:59:07 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christoph.muellner@...obroma-systems.com,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports

Hi Heiko,

Heiko Stuebner <heiko@...ech.de> wrote on Tue, 21 Jan 2020 14:45:10
+0100:

> From: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
> 
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
> ---
>  arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 9b1c92132007..37e014444214 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -421,19 +421,24 @@ lvds: lvds {
>  			rockchip,output = "lvds";
>  			status = "disabled";
>  
> -			port@0 {
> -				reg = <0>;
> +			ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> -				lvds_vopb_in: endpoint@0 {
> +				port@0 {
>  					reg = <0>;
> -					remote-endpoint = <&vopb_out_lvds>;
> -				};
> -
> -				lvds_vopl_in: endpoint@1 {
> -					reg = <1>;
> -					remote-endpoint = <&vopl_out_lvds>;
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					lvds_vopb_in: endpoint@0 {
> +						reg = <0>;
> +						remote-endpoint = <&vopb_out_lvds>;
> +					};
> +
> +					lvds_vopl_in: endpoint@1 {
> +						reg = <1>;
> +						remote-endpoint = <&vopl_out_lvds>;
> +					};
>  				};
>  			};
>  		};

I don't know the exact rule but this seems cleaner indeed.

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>


Thanks,
Miquèl