linux-kernel - Re: [v3] x86/tsc: Unset TSC_KNOWN_FREQ and TSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87eevs7lfd.fsf@nanos.tec.linutronix.de>
Date:   Tue, 21 Jan 2020 18:45:42 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vipul Kumar <vipulk0511@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Stable <stable@...r.kernel.org>,
        Srikanth Krishnakar <Srikanth_Krishnakar@...tor.com>,
        Cedric Hombourger <Cedric_Hombourger@...tor.com>,
        Vipul Kumar <vipulk0511@...il.com>, x86@...nel.org,
        Bin Gao <bin.gao@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Len Brown <len.brown@...el.com>,
        Vipul Kumar <vipul_kumar@...tor.com>
Subject: Re: [v3] x86/tsc: Unset TSC_KNOWN_FREQ and TSC_RELIABLE flags on Intel Bay Trail SoC

Vipul,

Vipul Kumar <vipulk0511@...il.com> writes:

> commit f3a02ecebed7 ("x86/tsc: Set TSC_KNOWN_FREQ and TSC_RELIABLE
> flags on Intel Atom SoCs"), is setting TSC_KNOWN_FREQ and TSC_RELIABLE
> flags for Soc's which is causing time drift on Valleyview/Bay trail Soc.

This lacks any form of information what the difference is. I asked about
that before and got no answer.

> This patch introduces a new macro to skip these flags.

git grep 'This patch' Documentation/process/submitting-patches.rst

> Signed-off-by: Vipul Kumar <vipul_kumar@...tor.com>
> Cc: stable@...r.kernel.org

That stable tag is useless as you already have identied the commit which
is "Fixed" by your patch.

>  
> +config X86_FEATURE_TSC_UNKNOWN_FREQ
> +	bool "Support to skip tsc known frequency flag"
> +	help
> +	  Include support to skip X86_FEATURE_TSC_KNOWN_FREQ flag
> +
> +	  X86_FEATURE_TSC_KNOWN_FREQ flag is causing time-drift on Valleyview/
> +	  Baytrail SoC.
> +	  By selecting this option, user can skip X86_FEATURE_TSC_KNOWN_FREQ
> +	  flag to use refine tsc freq calibration.

This is exactly the same problem as before. How does anyone aside of you
know whether to enable this or not?

And if someone enables this option then _ALL_ platforms which utilize
cpu_khz_from_msr() are affected. How is that any different from your
previous approach? This works on local kernels where you build for a
specific platform and you know exactly what you're doing, but not for
general consumption. What should a distro do with this option?

Thanks,

        tglx