linux-kernel - Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e274537.1c69fb81.a77e7.08fd@mx.google.com>
Date:   Tue, 21 Jan 2020 10:38:46 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Brian Masney <masneyb@...tation.org>,
        Lina Iyer <ilina@...eaurora.org>,
        Maulik Shah <mkshah@...eaurora.org>
Subject: Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake()

Quoting Bjorn Andersson (2020-01-21 10:35:19)
> On Tue 21 Jan 10:09 PST 2020, Stephen Boyd wrote:
> 
> >   __vfs_write+0x54/0x18c
> >   vfs_write+0xe4/0x1a4
> >   ksys_write+0x7c/0xe4
> >   __arm64_sys_write+0x20/0x2c
> >   el0_svc_common+0xa8/0x160
> >   el0_svc_handler+0x7c/0x98
> >   el0_svc+0x8/0xc
> > 
> > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
> 
> This lock used to protect the wake_irqs bitmap, and although your change
> indicates that the locking was wrong before this point I think the fixes
> should be:
> 
> Fixes: 6aced33f4974 ("pinctrl: msm: drop wake_irqs bitmap")
> 
> 
> Either way, the patch looks good.
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 

Ok. Thanks for fixing the Fixes tag.