linux-kernel - Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbPv_u_vMK_LjPc+p-hGoufx2KotcL=+Qp8_G=tXfaDOg@mail.gmail.com>
Date:   Thu, 23 Jan 2020 16:31:59 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Douglas Anderson <dianders@...omium.org>,
        Brian Masney <masneyb@...tation.org>,
        Lina Iyer <ilina@...eaurora.org>,
        Maulik Shah <mkshah@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake()

On Tue, Jan 21, 2020 at 7:09 PM Stephen Boyd <swboyd@...omium.org> wrote:

> We don't need to hold the local pinctrl lock here to set irq wake on the
> summary irq line. Doing so only leads to lockdep warnings instead of
> protecting us from anything. Remove the locking.
(...)
> Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Brian Masney <masneyb@...tation.org>
> Cc: Lina Iyer <ilina@...eaurora.org>
> Cc: Maulik Shah <mkshah@...eaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Fixed the Fixes: tag, added Björn's ACK and applied!

Yours,
Linus Walleij