linux-kernel - Re: [PATCH] KVM: async_pf: drop kvm_arch_async_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c2378317-6a8c-5a2e-aebe-e8d67b62bde3@de.ibm.com>
Date:   Tue, 21 Jan 2020 19:42:32 +0100
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH] KVM: async_pf: drop kvm_arch_async_page_present wrappers



On 21.01.20 14:48, Paolo Bonzini wrote:
> The wrappers make it less clear that the position of the call
> to kvm_arch_async_page_present depends on the architecture, and
> that only one of the two call sites will actually be active.
> Remove them.
> 
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

looks sane. The binary code also looks identical.

Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>


> ---
>  virt/kvm/async_pf.c | 21 ++++-----------------
>  1 file changed, 4 insertions(+), 17 deletions(-)
> 
> diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
> index d8ef708a2ef6..15e5b037f92d 100644
> --- a/virt/kvm/async_pf.c
> +++ b/virt/kvm/async_pf.c
> @@ -17,21 +17,6 @@
>  #include "async_pf.h"
>  #include <trace/events/kvm.h>
>  
> -static inline void kvm_async_page_present_sync(struct kvm_vcpu *vcpu,
> -					       struct kvm_async_pf *work)
> -{
> -#ifdef CONFIG_KVM_ASYNC_PF_SYNC
> -	kvm_arch_async_page_present(vcpu, work);
> -#endif
> -}
> -static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu,
> -						struct kvm_async_pf *work)
> -{
> -#ifndef CONFIG_KVM_ASYNC_PF_SYNC
> -	kvm_arch_async_page_present(vcpu, work);
> -#endif
> -}
> -
>  static struct kmem_cache *async_pf_cache;
>  
>  int kvm_async_pf_init(void)
> @@ -80,7 +65,8 @@ static void async_pf_execute(struct work_struct *work)
>  	if (locked)
>  		up_read(&mm->mmap_sem);
>  
> -	kvm_async_page_present_sync(vcpu, apf);
> +	if (IS_ENABLED(CONFIG_KVM_ASYNC_PF_SYNC))
> +		kvm_arch_async_page_present(vcpu, apf);
>  
>  	spin_lock(&vcpu->async_pf.lock);
>  	list_add_tail(&apf->link, &vcpu->async_pf.done);
> @@ -157,7 +143,8 @@ void kvm_check_async_pf_completion(struct kvm_vcpu *vcpu)
>  		spin_unlock(&vcpu->async_pf.lock);
>  
>  		kvm_arch_async_page_ready(vcpu, work);
> -		kvm_async_page_present_async(vcpu, work);
> +		if (!IS_ENABLED(CONFIG_KVM_ASYNC_PF_SYNC))
> +			kvm_arch_async_page_present(vcpu, work);
>  
>  		list_del(&work->queue);
>  		vcpu->async_pf.queued--;
>