linux-kernel - Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b6a7998-b6e3-6019-8588-18dbf622579a@acm.org>
Date:   Tue, 21 Jan 2020 21:13:14 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <huobean@...il.com>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct
 ufs_hba

On 2020-01-20 05:08, Bean Huo wrote:
> Without variable is_init_prefetch, the current logic can guarantee
> ufshcd_init_icc_levels() will execute only once, delete it now.

How about changing this description into the following:

A previous patch in this series introduced ufshcd_add_lus(). That
function is called once per HBA which makes the is_init_prefetch member
superfluous. Hence remove the is_init_prefetch member.

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>