linux-kernel - RE: [EXT] Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 10:13:06 +0000
From:   "Bean Huo (beanhuo)" <beanhuo@...ron.com>
To:     Bart Van Assche <bvanassche@....org>, Bean Huo <huobean@...il.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from
 struct ufs_hba

Hi, Bart

> 
> On 2020-01-20 05:08, Bean Huo wrote:
> > Without variable is_init_prefetch, the current logic can guarantee
> > ufshcd_init_icc_levels() will execute only once, delete it now.
> 
> How about changing this description into the following:
> 
> A previous patch in this series introduced ufshcd_add_lus(). That function is
> called once per HBA which makes the is_init_prefetch member superfluous.
> Hence remove the is_init_prefetch member.
> 
> Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Vielen Dank.  
Yes, I agree your commit message is better than mine. but they have the same final meaning.
And I see Martin has mainlined my patches,  if he need my next one, I will change to your description.

Thanks, 

//Bean