linux-kernel - Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9da004a1110b51d1737fe773901678b@codeaurora.org>
Date:   Thu, 23 Jan 2020 10:25:24 +0530
From:   kgunda@...eaurora.org
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Chen Zhou <chenzhou10@...wei.com>, agross@...nel.org,
        bjorn.andersson@...aro.org, lee.jones@...aro.org,
        jingoohan1@...il.com, b.zolnierkie@...sung.com,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to
 zero

On 2020-01-22 16:25, Daniel Thompson wrote:
> On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote:
>> Fixes coccicheck warning:
>> ./drivers/video/backlight/qcom-wled.c:1104:5-15:
>> 	WARNING: Unsigned expression compared with zero: string_len > 0
>> 
>> The unsigned variable string_len is assigned a return value from the 
>> call
>> to of_property_count_elems_of_size(), which may return negative error 
>> code.
>> 
>> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for 
>> WLED3")
>> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
> 
Reviewed-by: Kiran Gunda <kgunda@...eaurora.org>
>> ---
>> 
>> changes in v2:
>> - fix commit message description.
>> 
>> ---
>>  drivers/video/backlight/qcom-wled.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/video/backlight/qcom-wled.c 
>> b/drivers/video/backlight/qcom-wled.c
>> index d46052d..3d276b3 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int 
>> version)
>>  	struct wled_config *cfg = &wled->cfg;
>>  	struct device *dev = wled->dev;
>>  	const __be32 *prop_addr;
>> -	u32 size, val, c, string_len;
>> -	int rc, i, j;
>> +	u32 size, val, c;
>> +	int rc, i, j, string_len;
>> 
>>  	const struct wled_u32_opts *u32_opts = NULL;
>>  	const struct wled_u32_opts wled3_opts[] = {
>> --
>> 2.7.4
>>