linux-kernel - Re: [PATCH] riscv: change CSR M/S defines to use "X" for prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-55d1f282-e2ee-4ff3-b2c0-1701d175b426@palmerdabbelt-glaptop>
Date:   Wed, 22 Jan 2020 16:22:29 -0800 (PST)
From:   Palmer Dabbelt <palmerdabbelt@...gle.com>
To:     Olof Johansson <olof@...om.net>
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        tglx@...utronix.de, daniel.lezcano@...aro.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        jason@...edaemon.net, maz@...nel.org,
        Damien Le Moal <Damien.LeMoal@....com>,
        Christoph Hellwig <hch@....de>
Subject:     Re: [PATCH] riscv: change CSR M/S defines to use "X" for prefix

On Tue, 07 Jan 2020 03:15:56 PST (-0800), Paul Walmsley wrote:
> On Fri, 3 Jan 2020, Olof Johansson wrote:
>
>> Sure, this does the job. I'd personally prefer consistent prefixes but
>> that's just bikeshed color preferences -- this is fine.
>
> Thanks for the ack.  For what it's worth, we're in agreement that we
> should prophylactically place RV_ prefixes on the rest of the CSR_ macro
> names.  I just would prefer that it's done outside the late -rc series,
> since it's not technically a fix.

Olof: are you going to send a v2 of this patch that converts everything else
over or do you want me to?  I think we all agree it's the right way to go, Paul
was just trying to limit the scope of the change late in the RC cycle.  I'd
like to get this on for-next sooner rather than later as it'll probably
conflict with everything.

>> (Builds are still failing for some configs, but will be fixed if/when
>> you pick up https://lore.kernel.org/linux-riscv/20191217040631.91886-1-olof@lixom.net/)
>
> That one is on my radar - just haven't had a chance to review/test it
> yet.  Thanks for sending that one too!
>
>
> - Paul