[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEdQ38H-qRwcbcDVD_pEv9pGL33h=51kV3GYO87zSe9keZwT7A@mail.gmail.com>
Date: Wed, 22 Jan 2020 16:22:53 -0800
From: Matt Turner <mattst88@...il.com>
To: Tom Li <biergaizi2009@...il.com>
Cc: Lee Jones <lee.jones@...aro.org>, linux-mips@...r.kernel.org,
Paul Burton <paul.burton@...s.com>,
LKML <linux-kernel@...r.kernel.org>, Yifeng Li <tomli@...li.me>
Subject: Re: [PATCH 1/1] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote
Yeeloong laptops.
On Sat, Mar 30, 2019 at 1:19 AM Tom Li <biergaizi2009@...il.com> wrote:
>
> From: Yifeng Li <tomli@...li.me>
>
> Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor,
> primarily a demo platform for hobbyists and developers. It uses an
> ENE KB3310B Embedded Controller with customized firmware to implement
> hardware and power management.
>
> A monolithic platform driver code for those functionality has existed
> out-of-tree for many years. This commit creates a MFD driver for the EC
> chip on Yeeloong laptop to isolate EC-related code from core MIPS code,
> and serves as the foundation of various subdrivers.
>
> NOTE: A regmap could be the reasonable abstraction for I/O, but (1)
> it requires some additional refactoring to convert the shutdown/wakeup
> routines in board files to subdrivers, and (2) we're only using simple
> reads/writes, repmap only adds boilerplates to the existing files without
> additional benefits. We simply export the EC-related functions for now,
> until we come back to refactor the board files.
>
> Signed-off-by: Yifeng Li <tomli@...li.me>
Did you give up on upstreaming this code? That would be a shame, and
somewhat ironic given that you were frustrated about lack of review,
etc, and then never responded to the review given :(
Powered by blists - more mailing lists