linux-kernel - Re: [PATCH v3] perf/core: fix mlock accounting in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhed9pek.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Fri, 24 Jan 2020 11:25:55 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Song Liu <songliubraving@...com>, linux-kernel@...r.kernel.org
Cc:     kernel-team@...com, Song Liu <songliubraving@...com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v3] perf/core: fix mlock accounting in perf_mmap()

Song Liu <songliubraving@...com> writes:

> Eecreasing sysctl_perf_event_mlock between two consecutive perf_mmap()s of

Typo: "Decreasing".

> a perf ring buffer may lead to an integer underflow in locked memory
> accounting. This may lead to the undesired behaviors, such as failures in
> BPF map creation.
>
> Address this by adjusting the accounting logic to take into account the
> possibility that the amount of already locked memory may exceed the
> current limit.
>
> Fixes: c4b75479741c ("perf/core: Make the mlock accounting simple again")
> Signed-off-by: Song Liu <songliubraving@...com>
> Suggested-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>

Other than that,

Acked-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Thanks,
--
Alex