linux-kernel - Re: [linux-sunxi] [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2701584.e9J7NaK4W3@jernej-laptop>
Date:   Sat, 25 Jan 2020 12:24:31 +0100
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Chen-Yu Tsai <wens@...e.org>, linux-sunxi@...glegroups.com
Cc:     Maxime Ripard <mripard@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        jernej.skrabec@...l.net
Subject: Re: [linux-sunxi] [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions

Dne sobota, 25. januar 2020 ob 12:20:18 CET je Jernej Škrabec napisal(a):
> Hi!
> 
> Dne sobota, 25. januar 2020 ob 04:05:33 CET je Chen-Yu Tsai napisal(a):
> > On Sat, Jan 25, 2020 at 7:20 AM Jernej Skrabec <jernej.skrabec@...l.net>
> 
> wrote:
> > > For some reason, A64 and H6 have swapped clocks and resets definitions.
> > > H6 doesn't have rotation unit while A64 has. Swap around to correct the
> > > issue.
> > > 
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@...l.net>
> > 
> > Could you add Fixes tags for this one?
> 
> I'm not sure which commit to reference. H6 one? or also initial A64 one?
> 
> I just found out that H5 compatible uses A64 structure, which is not
> correct. H5 doesn't contain rotate core.
> 
> Do you have any better idea how to nicely solve this mess? I'm thinking that
> for v2 I would first decouple some compatibles, like this for H5 and R40
> and V3s from A83T (as it can be seen in the next patch). After that, rather
> than switching definitions I would fix each compatible one by one. At the
> end, if any entry is duplicated, I can add one commit to merge same
> structures.

This could also be a separate series of patches on which rotate driver series 
depends on.
 
Best regards,
Jernej