linux-kernel - Re: [PATCH] OCFS2: use OCFS2_SEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac7f6b5e-f62a-38a8-2511-e254c282e012@linux.alibaba.com>
Date:   Sun, 26 Jan 2020 09:47:06 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
        ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OCFS2: use OCFS2_SEC_BITS in macro



On 20/1/21 11:37, Alex Shi wrote:
> This macros should be used as it.
> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Mark Fasheh <mark@...heh.com> 
> Cc: Joel Becker <jlbec@...lplan.org> 
> Cc: Joseph Qi <joseph.qi@...ux.alibaba.com> 
> Cc: ocfs2-devel@....oracle.com 
> Cc: linux-kernel@...r.kernel.org

Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/dlmglue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index cda1027d0819..0d6daf49b72a 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -2133,7 +2133,7 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
>  }
>  
>  #define OCFS2_SEC_BITS   34
> -#define OCFS2_SEC_SHIFT  (64 - 34)
> +#define OCFS2_SEC_SHIFT  (64 - OCFS2_SEC_BITS)
>  #define OCFS2_NSEC_MASK  ((1ULL << OCFS2_SEC_SHIFT) - 1)
>  
>  /* LVB only has room for 64 bits of time here so we pack it for
>