linux-kernel - Re: [PATCH] OCFS2: remove dlm_lock_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 Jan 2020 09:48:41 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Richard Fontana <rfontana@...hat.com>,
        ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OCFS2: remove dlm_lock_is_remote



On 20/1/21 11:43, Alex Shi wrote:
> This macros is also not used from it was introduced. better to remove
> it.
> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Mark Fasheh <mark@...heh.com> 
> Cc: Joel Becker <jlbec@...lplan.org> 
> Cc: Joseph Qi <joseph.qi@...ux.alibaba.com> 
> Cc: Kate Stewart <kstewart@...uxfoundation.org> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> 
> Cc: Thomas Gleixner <tglx@...utronix.de> 
> Cc: Richard Fontana <rfontana@...hat.com> 
> Cc: ocfs2-devel@....oracle.com 
> Cc: linux-kernel@...r.kernel.org

Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com> 
> ---
>  fs/ocfs2/dlm/dlmthread.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 2dd9727537fe..0da9ffc40a88 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -39,8 +39,6 @@
>  static int dlm_thread(void *data);
>  static void dlm_flush_asts(struct dlm_ctxt *dlm);
>  
> -#define dlm_lock_is_remote(dlm, lock)     ((lock)->ml.node != (dlm)->node_num)
> -
>  /* will exit holding res->spinlock, but may drop in function */
>  /* waits until flags are cleared on res->state */
>  void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
>