linux-kernel - Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200126081941.GA794072@splinter>
Date:   Sun, 26 Jan 2020 10:19:41 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     jiri@...lanox.com, idosch@...lanox.com, davem@...emloft.net,
        vadimp@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in
 'mlxsw_m_port_create()'

On Sat, Jan 25, 2020 at 10:18:47PM +0100, Christophe JAILLET wrote:
> An 'alloc_etherdev()' called is not ballanced by a corresponding
> 'free_netdev()' call in one error handling path.
> 
> Slighly reorder the error handling code to catch the missed case.
> 
> Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

For net:

Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Thanks!