linux-kernel - Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200127.111442.1993972247561151893.davem@davemloft.net>
Date:   Mon, 27 Jan 2020 11:14:42 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     jiri@...lanox.com, idosch@...lanox.com, vadimp@...lanox.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in
 'mlxsw_m_port_create()'

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sat, 25 Jan 2020 22:18:47 +0100

> An 'alloc_etherdev()' called is not ballanced by a corresponding
> 'free_netdev()' call in one error handling path.
> 
> Slighly reorder the error handling code to catch the missed case.
> 
> Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied and queued up for -stable, thanks.