linux-kernel - Re: [PATCH] scripts/find-unused-docs: Fix massive false positives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200127142641.6e865467@lwn.net>
Date:   Mon, 27 Jan 2020 14:26:41 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jani Nikula <jani.nikula@...el.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/find-unused-docs: Fix massive false positives

On Mon, 27 Jan 2020 10:31:07 +0100
Geert Uytterhoeven <geert+renesas@...der.be> wrote:

> scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a
> source file contains kerneldoc or not.
> 
> However, as it passes the no longer supported "-text" option to
> scripts/kernel-doc, the latter prints out its help text, causing all
> files to be considered containing kerneldoc.
> 
> Get rid of these false positives by removing the no longer supported
> "-text" option from the scripts/kernel-doc invocation.
> 
> Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Sigh, I guess I should have tried that script before telling people to use
it.  Thanks for the fix; I've applied it with a CC: stable tag.

jon