linux-kernel - Re: [PATCH v9 1/2] fs: New zonefs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jan 2020 16:34:25 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Damien Le Moal <damien.lemoal@....com>,
        linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jth@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Naohiro Aota <naohiro.aota@....com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system

…
> +++ b/fs/zonefs/super.c
…
> +out:
> +	kunmap(page);
> +out_free:
> +	__free_page(page);


Would you like to reconsider your name selection for such labels?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460

Change possibility:

+unmap:
+	kunmap(page);
+free_page:
+	__free_page(page);


Regards,
Markus