linux-kernel - Re: [PATCH v9 1/2] fs: New zonefs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fe2d31c2f798b0768eec3ebc35bc973bc07ba1c.camel@wdc.com>
Date:   Wed, 29 Jan 2020 04:13:42 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>
CC:     "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "jth@...nel.org" <jth@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>, Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system

On Tue, 2020-01-28 at 16:34 +0100, Markus Elfring wrote:
> …
> > +++ b/fs/zonefs/super.c
> …
> > +out:
> > +	kunmap(page);
> > +out_free:
> > +	__free_page(page);
> 
> Would you like to reconsider your name selection for such labels?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
> 
> Change possibility:
> 
> +unmap:
> +	kunmap(page);
> +free_page:
> +	__free_page(page);
> 

Fixed. Thanks !

> 
> Regards,
> Markus

-- 
Damien Le Moal
Western Digital Research