linux-kernel - Re: [PATCH] dma: ti: dma-crossbar: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jan 2020 09:53:42 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     <qiwuchen55@...il.com>, <vkoul@...nel.org>,
        <dan.j.williams@...el.com>, <allison@...utok.net>,
        <kstewart@...uxfoundation.org>
CC:     <tglx@...utronix.de>, <wenwen@...uga.edu>,
        <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        chenqiwu <chenqiwu@...omi.com>
Subject: Re: [PATCH] dma: ti: dma-crossbar: convert to
 devm_platform_ioremap_resource()



On 28/01/2020 7.35, qiwuchen55@...il.com wrote:
> From: chenqiwu <chenqiwu@...omi.com>
> 
> Use a new API devm_platform_ioremap_resource() to simplify code.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> Signed-off-by: chenqiwu <chenqiwu@...omi.com>
> ---
>  drivers/dma/ti/dma-crossbar.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index f255056..4ba8fa5 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -133,7 +133,6 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
>  	const struct of_device_id *match;
>  	struct device_node *dma_node;
>  	struct ti_am335x_xbar_data *xbar;
> -	struct resource *res;
>  	void __iomem *iomem;
>  	int i, ret;
>  
> @@ -173,8 +172,7 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
>  		xbar->xbar_events = TI_AM335X_XBAR_LINES;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	iomem = devm_ioremap_resource(&pdev->dev, res);
> +	iomem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(iomem))
>  		return PTR_ERR(iomem);
>  
> @@ -323,7 +321,6 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
>  	struct device_node *dma_node;
>  	struct ti_dra7_xbar_data *xbar;
>  	struct property *prop;
> -	struct resource *res;
>  	u32 safe_val;
>  	int sz;
>  	void __iomem *iomem;
> @@ -403,8 +400,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
>  		kfree(rsv_events);
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	iomem = devm_ioremap_resource(&pdev->dev, res);
> +	iomem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(iomem))
>  		return PTR_ERR(iomem);
>  
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki