linux-kernel - Re: Re: [PATCH v2 0/9] Introduce Data Access MONitor (DAMON)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200128104942.11419-1-sjpark@amazon.com>
Date:   Tue, 28 Jan 2020 11:49:42 +0100
From:   <sjpark@...zon.com>
To:     Qian Cai <cai@....pw>
CC:     <sjpark@...zon.com>, <akpm@...ux-foundation.org>,
        SeongJae Park <sjpark@...zon.de>, <sj38.park@...il.com>,
        <acme@...nel.org>, <amit@...nel.org>, <brendan.d.gregg@...il.com>,
        <corbet@....net>, <dwmw@...zon.com>, <mgorman@...e.de>,
        <rostedt@...dmis.org>, <kirill@...temov.name>,
        <brendanhiggins@...gle.com>, <colin.king@...onical.com>,
        <minchan@...nel.org>, <vdavydov.dev@...il.com>,
        <vdavydov@...allels.com>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH v2 0/9] Introduce Data Access MONitor (DAMON)

On Tue, 28 Jan 2020 05:20:35 -0500 Qian Cai <cai@....pw> wrote:

> 
> 
> > On Jan 28, 2020, at 3:58 AM, sjpark@...zon.com wrote:
> > 
> > This patchset introduces a new kernel module for practical monitoring of data
> > accesses, namely DAMON.
> > 
> > The patches are organized in the following sequence.  The first four patches
> > implements the core logic of DAMON one by one.  After that, the fifth patch
> > implements DAMON's debugfs interface for users.  To provide a minimal reference
> > to the low level interface and for more convenient use/tests of the DAMON, the
> > sixth patch implements an user space tool.  The seventh patch adds a document
> > for administrators of DAMON, and the eightth patch provides DAMON's kunit
> > tests.  Finally, the ninth patch implements a tracepoint for DAMON.  As the
> > tracepoint prints every monitoring results, it will be easily integrated with
> > other tracers supporting tracepoints including perf.
> 
> I am a bit surprised that this patchset did not include perf maintainers which makes me wonder if there is any attempt to discuss first if we actually need a whole new subsystem for it or a existing tool can be enhanced.

For the comments from perf maintainers, I added Steven Rostedt and Arnaldo
Carvalho de Melo first, but I might missed someone.  If you recommend some more
people, I will add them to recipients.

I made DAMON as a new subsystem because I think no existing subsystem fits well
to be a base of DAMON, due to DAMON's unique goals and mechanisms described
below in the original cover letter.

The existing subsystem that most similar to DAMON might be 'mm/page_idle.c'.
However, there are many conceptual differences with DAMON.  One biggest
difference I think is the target.  'page_idle' deals with physical page frames
while DAMON deals with virtual address of specific processes.

Nevertheless, if you have some different opinion, please let me know.


Thanks,
SeongJae Park