[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHk-=whHZzyaRKu5WXTE7_mPaQPf-E-r=cZ+8YGVK5RPbzjt1g@mail.gmail.com>
Date: Mon, 27 Jan 2020 17:28:23 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Damien Le Moal <Damien.LeMoal@....com>
Cc: Markus Elfring <Markus.Elfring@....de>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Darrick J . Wong" <darrick.wong@...cle.com>,
Hannes Reinecke <hare@...e.de>,
Johannes Thumshirn <jth@...nel.org>,
Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system
On Mon, Jan 27, 2020 at 5:26 PM Damien Le Moal <Damien.LeMoal@....com> wrote:
>
> Yes, good catch. Furthermore, since this array is used only in
> zonefs_create_zgroup(), I moved its declaration on-stack in that function.
What?
Making it _local_ to that function makes sense, but not on stack.
Please keep it "static const char *[]" so that it isn't copied onto
the stack.
Linus
Powered by blists - more mailing lists