linux-kernel - Re: [PATCH v9 1/2] fs: New zonefs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR04MB581681ADF3F2F02BBF6A1B20E70A0@BYAPR04MB5816.namprd04.prod.outlook.com>
Date:   Tue, 28 Jan 2020 01:34:52 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Markus Elfring <Markus.Elfring@....de>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jth@...nel.org>,
        Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system

On 2020/01/28 10:28, Linus Torvalds wrote:
> On Mon, Jan 27, 2020 at 5:26 PM Damien Le Moal <Damien.LeMoal@....com> wrote:
>>
>> Yes, good catch. Furthermore, since this array is used only in
>> zonefs_create_zgroup(), I moved its declaration on-stack in that function.
> 
> What?
> 
> Making it _local_ to that function makes sense, but not on stack.
> Please keep it "static const char *[]" so that it isn't copied onto
> the stack.

Done. Thanks.

> 
>                Linus
> 
-- 
Damien Le Moal
Western Digital Research