linux-kernel - Re: [Patch V3 12/18] usb: gadget: tegra-xudc: support multiple device modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7478f53a-c236-5442-8abb-7531edb89b29@nvidia.com>
Date:   Wed, 29 Jan 2020 12:20:09 +0530
From:   Nagarjuna Kristam <nkristam@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <jonathanh@...dia.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <kishon@...com>,
        <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Patch V3 12/18] usb: gadget: tegra-xudc: support multiple device
 modes



On 28-01-2020 23:40, Thierry Reding wrote:
>>   	struct tegra_xudc_save_regs saved_regs;
>>   	bool suspended;
>>   	bool powergated;
>>   
>> -	struct usb_phy *usbphy;
>> +	struct usb_phy **usbphy;
>> +	int current_phy_index;
> Can be unsigned int. It's also very long. It might be better to choose a
> shorter name so that when you use it, the lines don't get excessively
> long. Alternatively you could keep this field name and instead declare
> local variables to reference the current PHY to make lines shorter.
> 
> Actually, looking at this a bit more, I don't see current_phy_index ever
> used by itself (other than the assignment and one check to see if a PHY
> has been selected). So why not just store a pointer to the current PHY
> and avoid all the dereferencing?
> 
> Thierry

current_phy_index main purpose is to quickly get which index for USB 2 
and 3 phy's to be used. This is used at mulitple functions. Based on 
your comment above, I believe its good to use 2 pointers for UTMI and 
USB 3 phy's, which are points to current phy index. This ensures to keep 
line length as less as possible.

Thanks,
Nagarjuna