[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200129083905.GB387@dell5510>
Date: Wed, 29 Jan 2020 09:39:05 +0100
From: Petr Vorel <pvorel@...e.cz>
To: Roberto Sassu <roberto.sassu@...wei.com>
Cc: zohar@...ux.ibm.com, jarkko.sakkinen@...ux.intel.com,
james.bottomley@...senpartnership.com,
linux-integrity@...r.kernel.org,
linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org, silviu.vlasceanu@...wei.com
Subject: Re: [PATCH 1/8] tpm: initialize crypto_id of allocated_banks to
HASH_ALGO__LAST
Hi Roberto,
> chip->allocated_banks contains the list of TPM algorithm IDs of allocated
> PCR banks. It also contains the corresponding ID of the crypto subsystem,
> so that users of the TPM driver can calculate a digest for a PCR extend
> operation.
> However, if there is no mapping between TPM algorithm ID and crypto ID, the
> crypto_id field in chip->allocated_banks remains set to zero (the array is
> allocated and initialized with kcalloc() in tpm2_get_pcr_allocation()).
> Zero should not be used as value for unknown mappings, as it is a valid
> crypto ID (HASH_ALGO_MD4).
> This patch initializes crypto_id to HASH_ALGO__LAST.
Make sense.
Reviewed-by: Petr Vorel <pvorel@...e.cz>
Kind regards,
Petr
Powered by blists - more mailing lists