linux-kernel - Re: [PATCH] cgroup.c: Use built-in RCU list checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200129160752.GA15913@madhuparna-HP-Notebook>
Date:   Wed, 29 Jan 2020 21:37:52 +0530
From:   Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To:     Michal Koutný <mkoutny@...e.com>
Cc:     madhuparnabhowmik10@...il.com, tj@...nel.org, lizefan@...wei.com,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        joel@...lfernandes.org, rcu@...r.kernel.org, frextrite@...il.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking

On Wed, Jan 29, 2020 at 03:22:55PM +0100, Michal Koutný wrote:
> Hello.
> 
> On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@...il.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> > 
> > list_for_each_entry_rcu has built-in RCU and lock checking.
> > Pass cond argument to list_for_each_entry_rcu() to silence
> > false lockdep warning when  CONFIG_PROVE_RCU_LIST is enabled
> > by default.
> I assume if you've seen the RCU warning, you haven't seen the warning
> from cgroup_assert_mutex_or_rcu_locked() above. 
>
No, I haven't seen any warning from cgroup_assert_mutex_or_rcu_locked(),
I am just doing the conversions to prevent any false lockdep warnings
because of CONFIG_PROVE_RCU_LIST in the future.

> The patch makes sense to me from the consistency POV.
> 
Thank you,
Madhuparna

> Acked-by: Michal Koutný <mkoutny@...e.com>
> 
> Michal