linux-kernel - Re: [PATCH] cgroup.c: Use built-in RCU list checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200212221249.GJ80993@mtj.thefacebook.com>
Date:   Wed, 12 Feb 2020 17:12:49 -0500
From:   Tejun Heo <tj@...nel.org>
To:     madhuparnabhowmik10@...il.com
Cc:     lizefan@...wei.com, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@...lfernandes.org,
        rcu@...r.kernel.org, frextrite@...il.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking

On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@...il.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when  CONFIG_PROVE_RCU_LIST is enabled
> by default.
> 
> Even though the function css_next_child() already checks if
> cgroup_mutex or rcu_read_lock() is held using
> cgroup_assert_mutex_or_rcu_locked(), there is a need to pass
> cond to list_for_each_entry_rcu() to avoid false positive
> lockdep warning.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>

Applied to cgroup/for-5.7.

Thanks.

-- 
tejun