linux-kernel - Re: [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jan 2020 19:27:25 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-usb@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1

On Wed, Jan 29, 2020 at 10:23:54AM -0800, Linus Torvalds wrote:
> On Wed, Jan 29, 2020 at 10:20 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > The I2C fix for this is in Wolfram's tree already:
> 
> It was never an i2c error.
> 
> It was an error in that commit that made a change that introduced a new warning.
> 
> It is *not* acceptable to break things and say "somebody else will fix
> it up later".
> 
> If it's broken in the PHY tree, then the PHY tree is broken. It's that simple.
> 
> We don't enable compile testing that causes warnings.

I never said it was an I2C error but only that the fix is there already.
The error in first place was mine because I did not spot the
bisectability problem when preparing the entire set of
compile-testing patches.

Best regards,
Krzysztof