[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOyeoRVaV3Dh=M4ioiT3DU+p5ZnQGRcy9_PssJZ=a36MhL-xHQ@mail.gmail.com>
Date: Wed, 29 Jan 2020 17:09:56 -0800
From: Eric Hankland <ehankland@...gle.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: Jim Mattson <jmattson@...gle.com>, Peter Shier <pshier@...gle.com>,
linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix perfctr WRMSR for running counters
Sorry - I forgot to switch to plain text mode on my first reply.
> I think this best written as it was before commit 2924b52117:
>
> if (!msr_info->host_initiated)
> data = (s64)(s32)data;
> pmc->counter += data - pmc_read_counter(pmc);
Sounds good to me.
> Do you have a testcase?
I added a testcase to kvm-unit-tests/x86/pmu.c that fails without this
patch and passes with it.
Should I send out that patch now?
Powered by blists - more mailing lists