linux-kernel - Re: [PATCH] KVM: x86: Fix perfctr WRMSR for running counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1cec3c8-570f-d824-cb20-6641cf686981@redhat.com>
Date:   Sat, 1 Feb 2020 19:51:40 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Eric Hankland <ehankland@...gle.com>
Cc:     Jim Mattson <jmattson@...gle.com>, Peter Shier <pshier@...gle.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix perfctr WRMSR for running counters

On 30/01/20 02:09, Eric Hankland wrote:
> Sorry - I forgot to switch to plain text mode on my first reply.
> 
>> I think this best written as it was before commit 2924b52117:
>>
>>                         if (!msr_info->host_initiated)
>>                                 data = (s64)(s32)data;
>>                         pmc->counter += data - pmc_read_counter(pmc);
> Sounds good to me.
> 
>> Do you have a testcase?
> I added a testcase to kvm-unit-tests/x86/pmu.c that fails without this
> patch and passes with it. Should I send out that patch now?

Yes, please send it!  Thanks,

Paolo