linux-kernel - Re: [Patch v2 0/4] mm/mremap: cleanup move_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com>
Date:   Fri, 31 Jan 2020 01:18:00 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>,
        akpm@...ux-foundation.org, aneesh.kumar@...ux.ibm.com,
        kirill@...temov.name, dan.j.williams@...el.com,
        yang.shi@...ux.alibaba.com, thellstrom@...are.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little

29.01.2020 03:26, Wei Yang пишет:
> move_page_tables() tries to move page table by PMD or PTE.
> 
> The root reason is if it tries to move PMD, both old and new range should
> be PMD aligned. But current code calculate old range and new range
> separately.  This leads to some redundant check and calculation.
> 
> This cleanup tries to consolidate the range check in one place to reduce
> some extra range handling.
> 
> v2:
>   * remove 3rd patch which doesn't work on ARM platform. Thanks report from
>     Dmitry Osipenko
> 
> Wei Yang (4):
>   mm/mremap: format the check in move_normal_pmd() same as
>     move_huge_pmd()
>   mm/mremap: it is sure to have enough space when extent meets
>     requirement
>   mm/mremap: calculate extent in one place
>   mm/mremap: start addresses are properly aligned
> 
>  include/linux/huge_mm.h |  2 +-
>  mm/huge_memory.c        |  8 +-------
>  mm/mremap.c             | 17 ++++++-----------
>  3 files changed, 8 insertions(+), 19 deletions(-)
> 

Hello Wei,

I haven't noticed any problems using the v2. Thank you very much for
addressing the problem!

Tested-by: Dmitry Osipenko <digetx@...il.com>