linux-kernel - Re: [Patch v2 0/4] mm/mremap: cleanup move_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200130230507.GA15192@richard>
Date:   Fri, 31 Jan 2020 07:05:07 +0800
From:   Wei Yang <richardw.yang@...ux.intel.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Wei Yang <richardw.yang@...ux.intel.com>,
        akpm@...ux-foundation.org, aneesh.kumar@...ux.ibm.com,
        kirill@...temov.name, dan.j.williams@...el.com,
        yang.shi@...ux.alibaba.com, thellstrom@...are.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little

On Fri, Jan 31, 2020 at 01:18:00AM +0300, Dmitry Osipenko wrote:
>29.01.2020 03:26, Wei Yang пишет:
>> move_page_tables() tries to move page table by PMD or PTE.
>> 
>> The root reason is if it tries to move PMD, both old and new range should
>> be PMD aligned. But current code calculate old range and new range
>> separately.  This leads to some redundant check and calculation.
>> 
>> This cleanup tries to consolidate the range check in one place to reduce
>> some extra range handling.
>> 
>> v2:
>>   * remove 3rd patch which doesn't work on ARM platform. Thanks report from
>>     Dmitry Osipenko
>> 
>> Wei Yang (4):
>>   mm/mremap: format the check in move_normal_pmd() same as
>>     move_huge_pmd()
>>   mm/mremap: it is sure to have enough space when extent meets
>>     requirement
>>   mm/mremap: calculate extent in one place
>>   mm/mremap: start addresses are properly aligned
>> 
>>  include/linux/huge_mm.h |  2 +-
>>  mm/huge_memory.c        |  8 +-------
>>  mm/mremap.c             | 17 ++++++-----------
>>  3 files changed, 8 insertions(+), 19 deletions(-)
>> 
>
>Hello Wei,
>
>I haven't noticed any problems using the v2. Thank you very much for
>addressing the problem!
>

Glad to hear this.

Actually, really thanks for your patience on testing and reporting the
problem.

Have a nice day :-)

>Tested-by: Dmitry Osipenko <digetx@...il.com>

-- 
Wei Yang
Help you, Help me