lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jan 2020 09:40:56 -0800 From: Davidlohr Bueso <dave@...olabs.net> To: "Paul E. McKenney" <paulmck@...nel.org> Cc: josh@...htriplett.org, linux-kernel@...r.kernel.org, will@...nel.org, peterz@...radead.org Subject: Re: [PATCH RFC locktorture] Print ratio of acquisitions, not failures On Thu, 23 Jan 2020, Paul E. McKenney wrote: >The __torture_print_stats() function in locktorture.c carefully >initializes local variable "min" to statp[0].n_lock_acquired, but >then compares it to statp[i].n_lock_fail. Given that the .n_lock_fail >field should normally be zero, and given the initialization, it seems >reasonable to display the maximum and minimum number acquisitions >instead of miscomputing the maximum and minimum number of failures. >This commit therefore switches from failures to acquisitions. This makes sense, thanks! > >Reported-by: Will Deacon <will@...nel.org> >Signed-off-by: Paul E. McKenney <paulmck@...nel.org> >Cc: Davidlohr Bueso <dave@...olabs.net> >Cc: Josh Triplett <josh@...htriplett.org> >Cc: Peter Zijlstra <peterz@...radead.org> Acked-by: Davidlohr Bueso <dbueso@...e.de>
Powered by blists - more mailing lists