linux-kernel - Re: [PATCH] dt-bindings: tpm: Convert cr50 binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5e34d5d3.1c69fb81.b5d48.eb80@mx.google.com>
Date:   Fri, 31 Jan 2020 17:35:14 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Rob Herring <robh@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS 
        <devicetree@...r.kernel.org>, Andrey Pronin <apronin@...omium.org>
Subject: Re: [PATCH] dt-bindings: tpm: Convert cr50 binding to YAML

Quoting Stephen Boyd (2020-01-09 08:08:11)
> Quoting Doug Anderson (2019-12-17 09:45:02)
> > On Mon, Dec 16, 2019 at 4:54 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > 
> > > +  spi-max-frequency:
> > > +    maxItems: 1
> > 
> > This is not an array type.  Why do you need maxItems?  Should treat
> > like an int?  Do we have any ranges of sane values we can put here?
> > I'm sure that there is a maximum that Cr50 can talk at.
> 
> From what I see looking through downstream sources my best guess for a
> max frequency is 1 MHz.
> 

I'm leaning towards dropping this property. Is there any benefit? The
driver should know the max anyway.